style changes #1

Closed

Arcenio wants to merge 0 commits from style into main

pull from: style

merge into: miniRT:main

miniRT:main

miniRT:issues

miniRT:fixes

miniRT:textures_final

miniRT:fix-render

miniRT:rendering

miniRT:textures

miniRT:line_part_2

miniRT:collision

miniRT:minimap

miniRT:basics

Conversation 2 Commits - Files changed -

Arcenio commented 2024-10-05 16:23:22 +00:00

Collaborator

Copy link

Changed style on nearly all files. Significantly slimmed down header prototypes in header, but also have more function prototypes in source files as a result. Moved "core functions" upwards so functions read in order they're encountered in.

Also made some modifications in terms of file names, function names, and slimmed down the Bresenham functions significantly

Pls share opinion

Changed style on nearly all files. Significantly slimmed down header prototypes in header, but also have more function prototypes in source files as a result. Moved "core functions" upwards so functions read in order they're encountered in. Also made some modifications in terms of file names, function names, and slimmed down the Bresenham functions significantly Pls share opinion

Arcenio added 3 commits 2024-10-05 16:23:24 +00:00

slimmed down Bresenham. style change in 3 files ... ec63d3309f

casting.c
config.c
line_drawing.c

deleted line_drawing_2.c

applied style changes to the rest ... d47d005028

Also changed some function and file names:
- made wall drawing function names more clear
- changed mlx_stuff.c to mlx_setup_and_loop.c

Forgot to add the renamed file to prior commit 824cb94601

Arcenio added 1 commit 2024-10-06 17:35:44 +00:00

fixed initial vertical line not drawing cb3a0d7567

Arcenio added 1 commit 2024-10-06 17:51:45 +00:00

minimap more transparent 8da6babd38

casper approved these changes 2024-10-07 14:41:06 +00:00

casper changed title from WIP: style changes to style changes 2024-10-07 14:41:24 +00:00

Arcenio commented 2024-10-07 15:56:50 +00:00

Author

Collaborator

Copy link

Pull requests are pretty neat.
I like this.

In other words: poggers.

Pull requests are pretty neat. I like this. In other words: poggers.

Arcenio closed this pull request 2024-10-07 15:56:52 +00:00

All checks were successful

Hide all checks

ci/woodpecker/pr/norm Pipeline was successful

Details

ci/woodpecker/push/norm Pipeline was successful

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

casper

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: miniRT/cub3D#1

No description provided.